answer Kepr 2's moved URLs with 301s and its retired ones with 410 Gone, refuse to sync bucket repos named like Kepr's own routes, and check the route list both ways (v3.0.42)

@@ -0,0 +1,52 @@1+import type { Hono } from "hono";2+import { isSafePath, isVersion } from "../bucket/repo.ts";3+import { notFound, type PageContext, pathUrl } from "./layout.ts";4+5+// §28: Kepr 2's addresses. Every move is a 301: none of them will ever point anywhere else.6+const PANELS = new Map([7+	["issues", "/issues"],8+	["builds", "/releases"],9+	["archives", "/archives"],10+	["trust", ""],11+]);12+// Accounts, tickets, drafts, feeds, and Koh 2's offer and protocol endpoints (Kepr 2's `protocol.zig`).13+const GONE = [14+	"/tickets/*",15+	"/drafts/*",16+	"/join",17+	"/cli-auth",18+	"/api/cli-auth/*",19+	"/api/repos/*",20+	"/api/releases/upload",21+	"/protocol/*",22+	"/feed",23+	"/:repo/feed",24+];25+// §22.1's own routes under `/<repo>/releases/`, which a version would otherwise shadow.26+const RELEASE_ROUTES = new Set(["latest", "latest.json", "history.json"]);27+28+/** Registered ahead of the repo page, so `/source` and the gone paths are never taken for repos. */29+export function registerKepr2Routes(app: Hono, ctx: PageContext): void {30+	for (const path of GONE) app.all(path, (c) => c.text("Gone", 410));31+	app.get("/source", (c) => c.redirect("/kepr", 301));32+	app.get("/:repo", async (c, next) => {33+		const panel = PANELS.get(c.req.query("panel") ?? "");34+		if (panel === undefined) return next();35+		return c.redirect(`/${encodeURIComponent(c.req.param("repo"))}${panel}`, 301);36+	});37+	app.get("/:repo/releases/:version", async (c, next) => {38+		const version = c.req.param("version");39+		if (RELEASE_ROUTES.has(version)) return next();40+		if (!isVersion(version)) return notFound(c, ctx);41+		return c.redirect(`/${encodeURIComponent(c.req.param("repo"))}/releases#${version}`, 301);42+	});43+	app.get("/:repo/file", (c) => {44+		const path = c.req.query("path") ?? "";45+		if (!isSafePath(path)) return notFound(c, ctx);46+		return c.redirect(`/${encodeURIComponent(c.req.param("repo"))}/files/${pathUrl(path)}`, 301);47+	});48+	app.get("/:repo/bundle", (c) => c.redirect(headTarball(c.req.param("repo")), 301));49+	app.get("/:repo/bundle.blake3", (c) => c.redirect(headTarball(c.req.param("repo")), 301));50+}51+52+const headTarball = (repo: string) => `/${encodeURIComponent(repo)}/archive/HEAD.tar.gz`;

@@ -0,0 +1,24 @@1+/**2+ * First path segments Kepr's own routes take (`docs/routes.txt`, §28's old paths included). A bucket3+ * repo of the same name would be shadowed by them, so the sync refuses it. A test holds this list to4+ * the app's registered routes.5+ */6+export const RESERVED_NAMES = new Set([7+	"admin",8+	"api",9+	"browse",10+	"cli-auth",11+	"docs",12+	"drafts",13+	"favicon.svg",14+	"feed",15+	"join",16+	"protocol",17+	"robots.txt",18+	"sign-in",19+	"sitemap.xml",20+	"source",21+	"static",22+	"support",23+	"tickets",24+]);

@@ -0,0 +1,102 @@1+import { expect, test } from "bun:test";2+import { cp, mkdtemp } from "node:fs/promises";3+import { tmpdir } from "node:os";4+import { join } from "node:path";5+import { createApp } from "../src/server/app.ts";6+import { openKeprDb } from "../src/server/db.ts";7+import { Browser, instance } from "./browser.ts";8+import { makeKohBucket } from "./fixture.ts";9+10+async function app() {11+	const dataDir = await mkdtemp(join(tmpdir(), "kepr-kepr2-"));12+	const config = {13+		domain: "kepr.example",14+		dataDir,15+		adminPasswordHash: "$argon2id$x",16+		bucket: { kind: "folder" as const, path: dataDir },17+	};18+	return createApp(config, openKeprDb(dataDir));19+}20+21+test("§28: Kepr 2's moved addresses answer 301 with the new one", async () => {22+	const kepr = await app();23+	const moves: [string, string][] = [24+		["/demo?panel=issues", "/demo/issues"],25+		["/demo?panel=builds", "/demo/releases"],26+		["/demo?panel=archives", "/demo/archives"],27+		["/demo?panel=trust", "/demo"],28+		["/demo/releases/2.1.0", "/demo/releases#2.1.0"],29+		["/demo/file?path=src/main.ts", "/demo/files/src/main.ts"],30+		["/demo/file?path=docs/a%20b.md", "/demo/files/docs/a%20b.md"],31+		["/demo/bundle", "/demo/archive/HEAD.tar.gz"],32+		["/demo/bundle.blake3", "/demo/archive/HEAD.tar.gz"],33+		["/source", "/kepr"],34+	];35+	for (const [from, to] of moves) {36+		const response = await kepr.request(from);37+		expect([from, response.status, response.headers.get("location")]).toEqual([from, 301, to]);38+	}39+});40+41+test("§28: Kepr 2's retired addresses answer 410 Gone, for any method", async () => {42+	const kepr = await app();43+	const gone = [44+		"/tickets",45+		"/tickets/new",46+		"/tickets/3",47+		"/drafts",48+		"/drafts/abc",49+		"/join",50+		"/cli-auth",51+		"/api/cli-auth/exchange",52+		"/api/cli-auth/session",53+		"/api/repos",54+		"/api/repos/demo/offer/negotiate",55+		"/api/repos/demo/offer/complete",56+		"/api/repos/demo/snapshot",57+		"/api/releases/upload",58+		"/protocol/v1/protocol.zig",59+		"/feed",60+		"/demo/feed",61+	];62+	for (const path of gone) {63+		expect([path, (await kepr.request(path)).status]).toEqual([path, 410]);64+		const post = await kepr.request(path, { method: "POST" });65+		expect([path, post.status]).toEqual([path, 410]);66+	}67+});68+69+test("the redirects shadow none of §22.1's routes, and refuse unsafe input", async () => {70+	const kepr = await app();71+	for (const path of [72+		"/demo/releases/latest",73+		"/demo/releases/latest.json",74+		"/demo/releases/history.json",75+		"/demo",76+		"/demo?panel=nope",77+		"/demo/file",78+		"/demo/file?path=../etc/passwd",79+		"/demo/file?path=a//b",80+		"/demo/releases/bad_version",81+	]) {82+		expect([path, (await kepr.request(path)).status]).toEqual([path, 404]);83+	}84+});85+86+test("a bucket repo named like one of Kepr's own routes is not synced, and the console says why", async () => {87+	const fx = await makeKohBucket();88+	await cp(join(fx.bucketDir, fx.repo), join(fx.bucketDir, "browse"), { recursive: true });89+	const inst = await instance(fx.bucketDir);90+	const rows = inst.kepr.query("SELECT name, last_sync_error FROM repos ORDER BY name").all();91+	const clash = `not synced: the name "browse" clashes with Kepr's own /browse route; rename the repo`;92+	expect(rows).toEqual([93+		{ name: "browse", last_sync_error: clash },94+		{ name: "demo", last_sync_error: null },95+	]);96+	expect(await Bun.file(join(inst.dataDir, "mirror/browse.db")).exists()).toBe(false);97+	const browser = new Browser(inst.app);98+	await browser.signIn();99+	expect(await (await browser.get("/admin/repos")).text()).toContain(100+		`sync error: ${clash.replaceAll('"', """).replaceAll("'", "'")}`,101+	);102+});