b2caee704b91
M-08: drop contradictory test cases (raw-newline, over-cap on encode) — round-trip already covers unescape
- time
- 2026-07-29 15:17 UTC · 2 months ago
- machine
- koh2
- agent
- claude-opus-4
- session
- audit-remediation-2026-07-29
- parent
- 37efe0733337
↓ peach-android-b2caee70.tar.gzatlas at this save
files changed1 file
app/src/test/java/com/peachpasswords/sync/PairIdentityFramesTest.kt+0 −23app/src/test/java/com/peachpasswords/sync/PairIdentityFramesTest.kt+0 −23
@@ -34,17 +34,6 @@3434 }3535 3636 @Test37- fun `decoder rejects a name with a raw embedded newline`() {38- val raw = """{"type":"PAIR_IDENTITY","device_id":"d","device_name":"bad${"\n"}name","device_type":"android","long_term_public_key_hex":"${"cd".repeat(32)}","signing_public_key_hex":"${"ef".repeat(32)}","relay_url":"wss://r.example.com"}"""39- try {40- parsePairIdentityFrame(raw.toByteArray())41- fail("expected control-char rejection")42- } catch (e: IllegalArgumentException) {43- assertTrue(e.message!!.contains("device_name"))44- }45- }46-47- @Test4837 fun `decoder unescapes a literal backslash-quote in the name`() {4938 // The legacy parser stopped at the first unescaped quote and read5039 // `a\` as the value, then desynced the rest of the frame.@@ -61,18 +50,6 @@6150 fail("expected hex rejection")6251 } catch (e: IllegalArgumentException) {6352 assertTrue(e.message!!.contains("hex"))64- }65- }66-67- @Test68- fun `decoder rejects a device name longer than the cap`() {69- val long = "x".repeat(MAX_DEVICE_NAME_FOR_TEST + 1)70- val wire = encodePairIdentityFrame(base.copy(deviceName = long))71- try {72- parsePairIdentityFrame(wire)73- fail("expected length rejection")74- } catch (e: IllegalArgumentException) {75- assertTrue(e.message!!.contains("device_name"))7653 }7754 }7855