admin M3 review fixes (v1.56.79): 6 review items. (1) BLOCKING was inverted — the DB is Postgres via pg_shim, NOT SQLite; SUM(BIGINT) returns numeric and pg_shim.columnI64 only decodes int2/4/8, so the ::bigint cast in adminLoadStorageBars is REQUIRED (without it storage sums read back 0). Kept the cast; added a real-Postgres regression test that runs the exact storage queries through pg_shim and asserts correct bytes WITH the cast and 0 WITHOUT (skips when no PG). Verified live against a throwaway PG; the only PG-suite failure (HTTP team-tier negotiate test) is pre-existing — fails identically on the pre-fix checkpoint, untouched by these fixes. (2) log SSE: emit failure now returns out of the whole handler (was an inner-only break that leaked a polling worker). (3) log tail: poll inclusively (since=last_ts) + de-dupe by counting file-lines consumed at the boundary second, fixing same-second line skips. (4) /admin/api/review now emits the stored agent_status (was hardcoded 'pending', drifting from detail). (5) loadPendingQueue label: alloc-new-then-free-old via temp to close the errdefer double-free window. (6) added missing errdefers on contributor_name + status_owned dupes in the key loaders
$ koh steal kepr.uk/kepr@d447a1bd77d8
·
parent: f0092a6e8359
discussion
log in to leave a comment.